This repository was archived by the owner on Apr 26, 2024. It is now read-only.
Fix deleting of old highlight notifications#15519
Closed
erikjohnston wants to merge 3 commits intodevelopfrom
Closed
Fix deleting of old highlight notifications#15519erikjohnston wants to merge 3 commits intodevelopfrom
erikjohnston wants to merge 3 commits intodevelopfrom
Conversation
Member
|
Mentioned in #6060 (comment), not sure if this fully fixes #6060 or not though? |
Member
Author
|
Oh wait, le sigh, we don't actually add highlights to the summary table. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In #13118 we accidentally stopped deleting old highlight notifications, and instead only deleted non-highlight notifications.
While we're here we also enforce that we use index scans (rather than seq scans), which we also do for state queries. The reason to enforce this is that we can't correctly get PostgreSQL to understand the distribution of
stream_orderingdepends onhighlight, and so it always defaults (on matrix.org) to sequential scans. This was especially exacerbated by us keeping old highlight notifications around.