Skip to content
This repository was archived by the owner on Apr 26, 2024. It is now read-only.

Revert update of hiredis in Poetry lockfile: revert from 2.1.0 to 2.0.0.#14718

Merged
reivilibre merged 2 commits intodevelopfrom
rei/hiredis_210_no_sdist
Dec 21, 2022
Merged

Revert update of hiredis in Poetry lockfile: revert from 2.1.0 to 2.0.0.#14718
reivilibre merged 2 commits intodevelopfrom
rei/hiredis_210_no_sdist

Conversation

@reivilibre
Copy link
Contributor

There is no source distribution for hiredis 2.1.0 so it is uninstallable on matrix.org as we use Pyston there.

Upstream: redis/hiredis-py#138

Base: develop

Original commit schedule, with full messages:

  1. Revert "Bump hiredis from 2.0.0 to 2.1.0 (Bump hiredis from 2.0.0 to 2.1.0 #14699)"
    This reverts commit 9c89707.

Signed-off-by: Olivier Wilkinson (reivilibre) <oliverw@matrix.org>
@reivilibre reivilibre marked this pull request as ready for review December 21, 2022 11:19
@reivilibre reivilibre requested a review from a team as a code owner December 21, 2022 11:19
@@ -0,0 +1 @@
Revert update of hiredis in Poetry lockfile: revert from 2.1.0 to 2.0.0. No newline at end of file
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm assuming we'll just delete this after the merge?

@clokep
Copy link
Member

clokep commented Jan 10, 2023

I think we can revert this now that they have a source distribution. That being said, 2.1.0 and 2.1.1 are mostly clean-ups of CI and infrastructure: https://github.com/redis/hiredis-py/blob/master/CHANGELOG.md#211-2023-10-01

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants