Skip to content
This repository was archived by the owner on Apr 26, 2024. It is now read-only.

Add aarch64 wheels to CI#14212

Merged
DMRobertson merged 4 commits intomatrix-org:developfrom
MichaIng:aarch64-wheels
Oct 18, 2022
Merged

Add aarch64 wheels to CI#14212
DMRobertson merged 4 commits intomatrix-org:developfrom
MichaIng:aarch64-wheels

Conversation

@MichaIng
Copy link
Contributor

@MichaIng MichaIng commented Oct 17, 2022 •
edited
Loading

Pull Request Checklist

  • Pull request is based on the develop branch
  • Pull request includes a changelog file. The entry should:
    • Be a short description of your change which makes sense to users. "Fixed a bug that prevented receiving messages from other servers." instead of "Moved X method from EventStore to EventWorkerStore.".
    • Use markdown where necessary, mostly for code blocks.
    • End with either a period (.) or an exclamation mark (!).
    • Start with a capital letter.
    • Feel free to credit yourself, by adding a sentence "Contributed by @github_username." or "Contributed by [Your Name]." to the end of the entry.
  • Pull request includes a sign off
  • Code style is correct
    (run the linters)

@MichaIng MichaIng requested a review from a team as a code owner October 17, 2022 21:09
@MichaIng MichaIng mentioned this pull request Oct 17, 2022
Closed
DMRobertson
DMRobertson reviewed Oct 18, 2022
View reviewed changes
@DMRobertson
Copy link
Contributor

DMRobertson commented Oct 18, 2022

Closes #13938.

@DMRobertson
Copy link
Contributor

DMRobertson commented Oct 18, 2022

@erikjohnston would you mind taking a look? I think this is sane and I think we're happy to publish arm wheels? Wanted to check though since you mentioned all the extra wheels being painful during the release process.

@DMRobertson
Copy link
Contributor

DMRobertson commented Oct 18, 2022

Run in progress at https://github.com/matrix-org/synapse/actions/runs/3268733324

erikjohnston
erikjohnston reviewed Oct 18, 2022
View reviewed changes
Copy link
Member

@erikjohnston erikjohnston left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I think this is sane, except for building aarch64 wheels on PRs

@clokep clokep linked an issue Oct 18, 2022 that may be closed by this pull request
Add aarch64 wheels to build workflow #13938
Closed
DMRobertson
DMRobertson suggested changes Oct 18, 2022
View reviewed changes
Copy link
Contributor

@DMRobertson DMRobertson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Huge thanks for working through this. Are you able to work through the comments we've raised?

@MichaIng
Copy link
Contributor Author

MichaIng commented Oct 18, 2022 •
edited
Loading

Are you able to work through the comments we've raised?

Yes will do. Do you prefer commits squashed/amended or separated?

@DMRobertson
Copy link
Contributor

DMRobertson commented Oct 18, 2022

Are you able to work through the comments we've raised?

Yes will do. Do you prefer commits squashed or separated?

Many thanks. Ideally separated on the PR: they'll get squash-merged at the end.

MichaIng and others added 3 commits October 18, 2022 15:28
@MichaIng
Add aarch64 wheels to CI
87efc0e 
Signed-off-by: MichaIng <micha@dietpi.com>
@MichaIng @DMRobertson
Enhance changelog entry regarding aarch64 wheels
850f101 
Co-authored-by: David Robertson <david.m.robertson1@gmail.com>
@MichaIng
Add target architecture to wheels build job name
db6291e 
Signed-off-by: MichaIng <micha@dietpi.com>
@DMRobertson DMRobertson self-requested a review October 18, 2022 13:38
DMRobertson
DMRobertson suggested changes Oct 18, 2022
View reviewed changes
Copy link
Contributor

@DMRobertson DMRobertson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than making this not build ARM wheels on PRs I think this is great---thanks again for working through the details.

@MichaIng
Don't build aarch64 wheels on PR CI
eac3f6e 
Signed-off-by: MichaIng <micha@dietpi.com>
DMRobertson
DMRobertson approved these changes Oct 18, 2022
View reviewed changes
Copy link
Contributor

@DMRobertson DMRobertson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again for picking this up when I dropped it!

@DMRobertson DMRobertson enabled auto-merge (squash) October 18, 2022 17:10
@DMRobertson DMRobertson merged commit 06b0c4e into matrix-org:develop Oct 18, 2022
@MichaIng MichaIng mentioned this pull request Oct 18, 2022
Closed
@MichaIng MichaIng deleted the aarch64-wheels branch October 18, 2022 17:35
This was referenced Oct 19, 2022
Closed
Closed
@richvdh richvdh mentioned this pull request Mar 2, 2023
Open
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

3 more reviewers

@erikjohnston erikjohnston erikjohnston left review comments

@Joulinar Joulinar Joulinar left review comments

@DMRobertson DMRobertson DMRobertson approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add aarch64 wheels to build workflow

4 participants

@MichaIng @DMRobertson @erikjohnston @Joulinar