This repository was archived by the owner on Apr 26, 2024. It is now read-only.
Update the SSO username picker template to comply with SIWA guidelines #12210
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Would also like a check from @nadonomy on the copy before it goes in (looks like I can't request reviews from Nad on this repo). |
richvdh
reviewed
Mar 11, 2022
richvdh
suggested changes
Mar 11, 2022
Contributor
Author
|
I've had a chat out-of-bound with @nadonomy and it sounds like the changes are fine, so let's merge it and get it deployed it soon. |
nadonomy
reviewed
Mar 21, 2022
Contributor
nadonomy
left a comment
There was a problem hiding this comment.
@babolivier @callahad sorry PEBKAC on my behalf for not submitting this before. Would be great to get this right given the pedantry at review time.
| <header> | ||
| <h1>Your account is nearly ready</h1> | ||
| <p>Check your details before creating an account on {{ server_name }}</p> | ||
| <h1>Choose your user name</h1> |
Contributor
There was a problem hiding this comment.
@babolivier Per the issue this should be:
Choose your account name
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #12205
cc @reivilibre