This repository was archived by the owner on Apr 26, 2024. It is now read-only.
Closed
Conversation
c5cfdc2 to
708c163
Compare
babolivier
suggested changes
Oct 6, 2021
DMRobertson
suggested changes
Oct 6, 2021
Contributor
DMRobertson
left a comment
There was a problem hiding this comment.
Mostly just general comments, but the V2/V3 typo needs a fix I think!
Co-authored-by: Brendan Abolivier <babolivier@matrix.org>
DMRobertson
reviewed
Oct 12, 2021
Comment on lines
+1496
to
+1501
| conflicting_insertion_event_id = None | ||
| if next_batch_id: | ||
| conflicting_insertion_event_id = ( | ||
| await self.store.get_insertion_event_by_batch_id( | ||
| event.room_id, next_batch_id | ||
| ) |
Contributor
There was a problem hiding this comment.
At first glance, this looks like it might be a bug fix; does something bad happen if we pass next_batch_id=None to get_insertion_event_by_batch_id? Or perhaps the preceeding code was such that next_batch_id was never None, and we just need to convince mypy of that?
DMRobertson
approved these changes
Oct 12, 2021
Member
Author
|
I'm finding this PR unwieldy. I'm going to split it in half. |
DMRobertson
reviewed
Oct 12, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds missing type hints to the
synapse.eventsmodule and ensures mypy checks them.There are still some missing type hints around the
DictPropertyfield (andEventBase, kind of). There's some deep magic there and my attempts to add type hints caused many errors throughout the code-base. I think doing that separately is probably desired.