Skip to content
This repository was archived by the owner on Apr 26, 2024. It is now read-only.
This repository was archived by the owner on Apr 26, 2024. It is now read-only.

Delete Local Media Admin APIs unnecessarily requires specifying local server_name #9284

@anoadragon453

Description

@anoadragon453

The Delete Local Media Admin APIs require you to include the server name of your local homeserver in the path parameters. If you provide something other than the correct server name, the request will be rejected.

There doesn't seem to be much point in that, especially when the remote media deletion admin APIs don't allow specifying a server name.

It's also confusing as people see POST /_synapse/admin/v1/media/<server_name>/delete?before_ts=<before_ts> and assume it works for any given server name, as seen here: #3479 (comment)

I believe this may have come from existing Media Admin APIs, such as Quarantine Media, which required a server_name path parameter, where any server name could be specified.

We should rework this to remove the requirement of specifying the local server name - which is already known by the homeserver, and possibly make it a bit more obvious from the path that this is for local media only.

Metadata

Metadata

Assignees

No one assigned

    Labels

    A-Admin-APIA-Media-RepositoryUploading, downloading images and video, thumbnailingT-TaskRefactoring, removal, replacement, enabling or disabling functionality, other engineering tasks.

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions