Skip to content
This repository was archived by the owner on Apr 26, 2024. It is now read-only.

Bump requests-toolbelt from 0.10.1 to 1.0.0.#16659

Merged
clokep merged 3 commits intodevelopfrom
clokep/update-requests-toolbelt
Nov 17, 2023
Merged

Bump requests-toolbelt from 0.10.1 to 1.0.0.#16659
clokep merged 3 commits intodevelopfrom
clokep/update-requests-toolbelt

Conversation

@clokep
Copy link
Member

@clokep clokep commented Nov 17, 2023

This will fix an incompatibility with Twine, types-requests, requests, requests-toolbelt, and urllib3 (or some combination of the dependencies of those). See pypa/twine#989 (comment)

@clokep clokep marked this pull request as ready for review November 17, 2023 14:17
@clokep clokep requested a review from a team as a code owner November 17, 2023 14:17
Copy link
Contributor

@DMRobertson DMRobertson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like we only pull this in due to twine:

 $ poetry show --tree --why requests-toolbelt
twine 4.0.2 Collection of utilities for publishing packages on PyPI
└── requests-toolbelt >=0.8.0,<0.9.0 || >0.9.0
    └── requests >=2.0.1,<3.0.0 
        ├── certifi >=2017.4.17 
        ├── charset-normalizer >=2,<4 
        ├── idna >=2.5,<4 
        └── urllib3 >=1.21.1,<3 

so this should only affect doing releases.

@clokep clokep merged commit d9dcfe2 into develop Nov 17, 2023
@clokep clokep deleted the clokep/update-requests-toolbelt branch November 17, 2023 15:23
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants