This repository was archived by the owner on Apr 26, 2024. It is now read-only.
Speed up persisting large number of outliers#16649
Merged
erikjohnston merged 2 commits intodevelopfrom Nov 16, 2023
Merged
Conversation
be10458 to
2441b37
Compare
clokep
reviewed
Nov 16, 2023
clokep
approved these changes
Nov 16, 2023
| heapq.heappush(zero_degree, edge) | ||
|
|
||
|
|
||
| def sorted_topologically_batched( |
Member
There was a problem hiding this comment.
FWIW I think sorted_topologically could become
def sorted_topologically(nodes, graph):
for batch in sorted_topologically_batched(nodes, graph):
yield from batchIt would probably create a bunch of intermediate lists and such though, which is unnecessary.
Member
Author
There was a problem hiding this comment.
Yes, ish. I think sorted_topologically gives a lexicographical topological sort, which could return a slightly different order (though I don't think we really rely on that fact anywhere, so)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Recalculating the roots tuple every iteration could be very expensive, so instead let's do a topological sort.
(Note that
sorted_topologically_batchedis basically a slightly modifiedsorted_topologically, and the tests are more or less a copy and paste)