This repository was archived by the owner on Apr 26, 2024. It is now read-only.
Conversation
clokep
commented
Nov 3, 2023
Comment on lines
-2295
to
-2296
| if clauses: | ||
| sql = "%s WHERE %s" % (sql, " AND ".join(clauses)) |
Member
Author
There was a problem hiding this comment.
There's always at least 1 clause, so this is just a minor clean-up.
clokep
commented
Nov 3, 2023
DMRobertson
approved these changes
Nov 6, 2023
Contributor
DMRobertson
left a comment
There was a problem hiding this comment.
Looks sensible; no objections. Not sure I understand what the difficulty is with postgres though. Shout if you want a rubber duck.
| "DELETE FROM tablename WHERE keycol = ?", ["Go away"] | ||
| ) | ||
|
|
||
| @defer.inlineCallbacks |
Contributor
There was a problem hiding this comment.
I guess twisted/trial doesn't let you write test methods using async def ...? :(
Member
Author
There was a problem hiding this comment.
They do, but I think not on our lowest bound. I started testing it and got into some dependency hell and stopped.
Member
Author
|
@DMRobertson Thanks for the feedback, can you take another look? I've:
|
DMRobertson
reviewed
Nov 7, 2023
DMRobertson
approved these changes
Nov 7, 2023
Contributor
DMRobertson
left a comment
There was a problem hiding this comment.
Thanks for tolerating my pedantry :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After being a bit nervous about #16583, I wanted to write some tests for more of the
simple_*methods of theDatabasePool.