This repository was archived by the owner on Apr 26, 2024. It is now read-only.
Collect information for PushRuleEvaluator in parallel.#16590
Merged
Conversation
eda4866 to
d1f0966
Compare
Member
Author
|
This has some type hint issues, I think... |
d1f0966 to
d962188
Compare
DMRobertson
approved these changes
Nov 6, 2023
Contributor
DMRobertson
left a comment
There was a problem hiding this comment.
Seems sane to me. Interested to see if this has a measurable impact!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
PushRuleEvaluatorrequires a bunch of information about the room / sender, etc. based on the new event, most of this information does not depend on each other and can be calculated in parallel.Additionally
bulk_get_push_ruleshas two separate queries which can be done in parallel.Ideally we would use PostgreSQL pipeling here instead, but that's not available to use in psycopg2 (or PostgreSQL < 14).
Note that these queries running in parallel will still be subject to thread pool contention, but worse case they get serialized, as they are today.