Skip to content
This repository was archived by the owner on Apr 26, 2024. It is now read-only.

Clients link fixed in README#16569

Merged
DMRobertson merged 3 commits intomatrix-org:developfrom
niranjan-kurhade:readme-client-link-fix
Oct 30, 2023
Merged

Clients link fixed in README#16569
DMRobertson merged 3 commits intomatrix-org:developfrom
niranjan-kurhade:readme-client-link-fix

Conversation

@niranjan-kurhade
Copy link
Contributor

@niranjan-kurhade niranjan-kurhade commented Oct 28, 2023

In this PR, I have fixed the broken link of clients in the README file. Now it redirects to the correct link.

Pull Request Checklist

  • Pull request is based on the develop branch
  • Pull request includes a changelog file. The entry should:
    • Be a short description of your change which makes sense to users. "Fixed a bug that prevented receiving messages from other servers." instead of "Moved X method from EventStore to EventWorkerStore.".
    • Use markdown where necessary, mostly for code blocks.
    • End with either a period (.) or an exclamation mark (!).
    • Start with a capital letter.
    • Feel free to credit yourself, by adding a sentence "Contributed by @github_username." or "Contributed by [Your Name]." to the end of the entry.
  • Pull request includes a sign off
  • Code style is correct
    (run the linters)

@niranjan-kurhade niranjan-kurhade requested a review from a team as a code owner October 28, 2023 20:43
@niranjan-kurhade
Copy link
Contributor Author

niranjan-kurhade commented Oct 29, 2023

Hey @DMRobertson @clokep Can you please review my PR?

@DMRobertson DMRobertson mentioned this pull request Oct 29, 2023
Open
@DMRobertson DMRobertson linked an issue Oct 29, 2023 that may be closed by this pull request
Broken link (client breakdown) in README #16568
Closed
DMRobertson
DMRobertson suggested changes Oct 30, 2023
View reviewed changes
Copy link
Contributor

@DMRobertson DMRobertson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @DMRobertson @clokep Can you please review my PR?

PRs are automatically put into a queue and reviewed when we can get to them. You're unlikely to get an immediate response on a weekend, however.

This seems sane to me. Please add a changelog entry and sign-off per the PR template.

@niranjan-kurhade
Added Changelog file
415ab75 
Signed-off-by: Niranjan Kurhade <niranjandk03@gmail.com>
@niranjan-kurhade
Copy link
Contributor Author

niranjan-kurhade commented Oct 30, 2023

Hey @DMRobertson @clokep Can you please review my PR?

PRs are automatically put into a queue and reviewed when we can get to them. You're unlikely to get an immediate response on a weekend, however.

This seems sane to me. Please add a changelog entry and sign-off per the PR template.

Hey @DMRobertson Sorry for tagging, I have now added my Changelog file and signed off as well.

DMRobertson
DMRobertson approved these changes Oct 30, 2023
View reviewed changes
Copy link
Contributor

@DMRobertson DMRobertson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@DMRobertson DMRobertson enabled auto-merge (squash) October 30, 2023 16:04
@DMRobertson DMRobertson merged commit 91aa52c into matrix-org:develop Oct 30, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@DMRobertson DMRobertson DMRobertson approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Broken link (client breakdown) in README

2 participants

@niranjan-kurhade @DMRobertson