Skip to content
This repository was archived by the owner on Apr 26, 2024. It is now read-only.

Portdb: don't copy a table that gets rebuilt#16563

Merged
DMRobertson merged 2 commits intodevelopfrom
dmr/fix-portdb-typo
Oct 27, 2023
Merged

Portdb: don't copy a table that gets rebuilt#16563
DMRobertson merged 2 commits intodevelopfrom
dmr/fix-portdb-typo

Conversation

@DMRobertson
Copy link
Contributor

@DMRobertson DMRobertson commented Oct 27, 2023 •
edited
Loading

The table itself is fine to port over AFAICS:

CREATE TABLE IF NOT EXISTS users_in_public_rooms (
    user_id TEXT NOT NULL,
    room_id TEXT NOT NULL
);

But I think the user directory is deliberately rebuilt after porting (the FTS tables aren't portable).

Typo 1 introduced in #2375, moved in #7711, then changed to typo 2 in #7717.

@DMRobertson DMRobertson changed the title Fix typo in port db script. Portdb: don't copy a table that gets rebuilt Oct 27, 2023
@DMRobertson DMRobertson marked this pull request as ready for review October 27, 2023 16:58
@DMRobertson DMRobertson requested a review from a team as a code owner October 27, 2023 16:58
@clokep
Copy link
Member

clokep commented Oct 27, 2023

Typo introduced in #7717.

A different typo existed before that. 😢

@DMRobertson
Copy link
Contributor Author

DMRobertson commented Oct 27, 2023

Port db tests were happy, ignoring what I assume to be sytest flakes.

@DMRobertson DMRobertson merged commit 747416e into develop Oct 27, 2023
@DMRobertson DMRobertson deleted the dmr/fix-portdb-typo branch October 27, 2023 19:14
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@clokep clokep clokep approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@DMRobertson @clokep