This repository was archived by the owner on Apr 26, 2024. It is now read-only.
Ensure local invited & knocking users leave before purge.#16559
Merged
Ensure local invited & knocking users leave before purge.#16559
Conversation
DMRobertson
approved these changes
Oct 27, 2023
Contributor
DMRobertson
left a comment
There was a problem hiding this comment.
Seems reasonable. How confident are we that the leaves are broadcast to invited and knocking users? I'm guessing that this behaves in exactly the same way as the join->leave transition for joined users?
Member
Author
It should...except none of these are transmitted to users during the purging process due to #16001. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently when we purge a room only joined local users leave the room, stranding invites and knocking users in their old state.
This isn't a huge deal since well...you've purged the room and your own server doesn't know about it anymore. Other servers, however, will still see those users in those states and we should properly clean-up.