This repository was archived by the owner on Apr 26, 2024. It is now read-only.
Add new module API for adding custom fields to events unsigned section#16549
Merged
erikjohnston merged 8 commits intodevelopfrom Oct 27, 2023
Merged
Add new module API for adding custom fields to events unsigned section#16549erikjohnston merged 8 commits intodevelopfrom
unsigned section#16549erikjohnston merged 8 commits intodevelopfrom
Conversation
64253d2 to
f607aeb
Compare
DMRobertson
reviewed
Oct 25, 2023
DMRobertson
reviewed
Oct 25, 2023
Comment on lines
+19
to
+23
| ```python | ||
| async def add_field_to_unsigned( | ||
| event: EventBase, | ||
| ) -> JsonDict: | ||
| ``` |
Contributor
There was a problem hiding this comment.
Thoughts:
- the module doesn't know who the event is destined for. Would it be useful to include a receipient mxid/device here? (I'm thinking of e.g. txn ids, which we only send down to the device that requested it). I expect the answer is "we don't need it now, but we can add it in the future if it's necessary".
- Could the callback return different things in different invocations for the same event? If so---do we care/need to worry?
Member
Author
There was a problem hiding this comment.
- I think it could be useful in the future, but it's not needed for now and I don't really want to have to do the refactoring to support it right now. As you say, its easy to add later.
- Yes, the callback can give different things for the same event, but that doesn't matter
DMRobertson
approved these changes
Oct 25, 2023
Contributor
DMRobertson
left a comment
There was a problem hiding this comment.
I've left a few thoughts that it would be good to check up on before commiting, but otherwise LGMT
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.