This repository was archived by the owner on Apr 26, 2024. It is now read-only.
Convert user_get_threepids response to attrs.#16468
Merged
Conversation
DMRobertson
reviewed
Oct 11, 2023
| retcols=["medium", "address", "validated_at", "added_at"], | ||
| desc="user_get_threepids", | ||
| ) | ||
| return [ThreepidResult(**r) for r in results] |
Contributor
There was a problem hiding this comment.
Does this mean that simple_select_list is still calling cursor_to_dict?
Member
Author
There was a problem hiding this comment.
Yeah, this is to reduce the diff in the branch.
DMRobertson
approved these changes
Oct 11, 2023
Contributor
DMRobertson
left a comment
There was a problem hiding this comment.
LGTM, assuming that simple_select_list hasn't yet been de-dictionaried. I double checked the DB column types too.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is related to #16431, but mostly just improves our type hints.