This repository was archived by the owner on Apr 26, 2024. It is now read-only.
Convert simple_search_list/simple_search_list_txn to return tuples.#16434
Merged
Convert simple_search_list/simple_search_list_txn to return tuples.#16434
Conversation
DMRobertson
reviewed
Oct 5, 2023
DMRobertson
reviewed
Oct 5, 2023
DMRobertson
reviewed
Oct 5, 2023
DMRobertson
reviewed
Oct 5, 2023
Contributor
DMRobertson
left a comment
There was a problem hiding this comment.
Happy with the change at large, but I'm not sure what we should do about the boolean-but-ints-on-sqlite and nullable-but-hopefully-not columns.
Member
Author
|
Also filed #16443 about there being no docs for this endpoint. |
DMRobertson
reviewed
Oct 10, 2023
Contributor
DMRobertson
left a comment
There was a problem hiding this comment.
Looks good, but complement is failing in a way I don't recognise. Is it a regression?
Member
Author
Seems to be failing on develop in the same way: https://github.com/matrix-org/synapse/actions/runs/6469190463/job/17562829355 |
DMRobertson
approved these changes
Oct 10, 2023
Contributor
DMRobertson
left a comment
There was a problem hiding this comment.
In that case, happy for this to land. I'll try to investigate develop when I can!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
More removals of
cursor_to_dict. This one might be controversial since it just manually creates the dict at the REST layer.I assert that this is better because it is explicit about the information we return to clients, as opposed to choosing from the database layer.
It also does a couple of other simplifications while I was there.
See #16431.