Skip to content
This repository was archived by the owner on Apr 26, 2024. It is now read-only.

Fix possible AttributeError when account-api is called over unix socket#16404

Merged
erikjohnston merged 3 commits intomatrix-org:developfrom
shtrophic:develop
Oct 9, 2023
Merged

Fix possible AttributeError when account-api is called over unix socket#16404
erikjohnston merged 3 commits intomatrix-org:developfrom
shtrophic:develop

Conversation

@shtrophic
Copy link
Contributor

@shtrophic shtrophic commented Sep 30, 2023 •
edited
Loading

Fixes #16396

Pull Request Checklist

  • Pull request is based on the develop branch
  • Pull request includes a changelog file. The entry should:
    • Be a short description of your change which makes sense to users. "Fixed a bug that prevented receiving messages from other servers." instead of "Moved X method from EventStore to EventWorkerStore.".
    • Use markdown where necessary, mostly for code blocks.
    • End with either a period (.) or an exclamation mark (!).
    • Start with a capital letter.
    • Feel free to credit yourself, by adding a sentence "Contributed by @github_username." or "Contributed by [Your Name]." to the end of the entry.
  • Pull request includes a sign off via email
  • Code style is correct
    (run the linters)

@shtrophic shtrophic requested a review from a team as a code owner September 30, 2023 01:59
erikjohnston
erikjohnston approved these changes Oct 6, 2023
View reviewed changes
Copy link
Member

@erikjohnston erikjohnston left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@erikjohnston
Copy link
Member

erikjohnston commented Oct 6, 2023

@Sir-Photch you need to sign off this PR, as per the contributing guide.

@shtrophic
Copy link
Contributor Author

shtrophic commented Oct 6, 2023 •
edited
Loading

@erikjohnston I've sent you guys an email about that

@InezMc
Copy link

InezMc commented Oct 9, 2023

Private sign off has been recieved.

@Sir-Photch you need to sign off this PR, as per the contributing guide.

@erikjohnston
Copy link
Member

erikjohnston commented Oct 9, 2023

Thanks both!

@erikjohnston erikjohnston merged commit 32fd9bc into matrix-org:develop Oct 9, 2023
@erikjohnston erikjohnston mentioned this pull request Oct 9, 2023
Merged
@shtrophic shtrophic mentioned this pull request Dec 10, 2023
Open
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@erikjohnston erikjohnston erikjohnston approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Calls to /_matrix/client/v3/account/whoami return 500 when called on a unix socket

3 participants

@shtrophic @erikjohnston @InezMc