Skip to content
This repository was archived by the owner on Apr 26, 2024. It is now read-only.
This repository was archived by the owner on Apr 26, 2024. It is now read-only.

Complement TestPartialStateJoin/Outgoing_device_list_updates/Device_list_updates_reach_newly_joined_servers_in_partial_state_rooms is flakey #14010

@squahtx

Description

@squahtx

https://github.com/matrix-org/synapse/actions/runs/3172224388/jobs/5166469780#step:4:2964

      client.go:604: [CSAPI] GET hs1/_matrix/client/v3/sync => 200 OK (125.434036ms)
      federation_room_join_partial_state_test.go:1674: @t24alice:hs1's partial state join to !0:host.docker.internal:38237 completed.
      client.go:604: [CSAPI] PUT hs1/_matrix/client/v3/devices/PBJFBBTZIN => 200 OK (18.65378ms)
      federation_room_join_partial_state_test.go:1677: @t24alice:hs1 sent device list update.
      federation_room_join_partial_state_test.go:1534: Complement server received m.device_list_update: {"device_display_name":"A new device name 3","device_id":"PBJFBBTZIN","org.matrix.opentracing_context":"{}","prev_id":[35],"stream_id":38,"user_id":"@t24alice:hs1"}
      federation_room_join_partial_state_test.go:1534: Complement server received m.device_list_update: {"device_display_name":"A new device name 3","device_id":"PBJFBBTZIN","org.matrix.opentracing_context":"{}","prev_id":[36],"stream_id":40,"user_id":"@t24alice:hs1"}
      federation_room_join_partial_state_test.go:1680: @charlie, @derek and @elsie received device list update.
      federation_room_join_partial_state_test.go:1534: Complement server received m.device_list_update: {"device_display_name":"A new device name 3","device_id":"PBJFBBTZIN","org.matrix.opentracing_context":"{}","prev_id":[38],"stream_id":39,"user_id":"@t24alice:hs1"}
  panic: test timed out after 1h0m0s
  
  goroutine 3428 [running]:
  testing.(*M).startAlarm.func1()
  	/opt/hostedtoolcache/go/1.17.13/x64/src/testing/testing.go:1788 +0x8e
  created by time.goFunc
  	/opt/hostedtoolcache/go/1.17.13/x64/src/time/sleep.go:180 +0x31

Synapse sent an extra device update, which the test wasn't interested in. I think putting the device update in a channel blocked, and then the test timed out after an hour.

Metadata

Metadata

Assignees

No one assigned

    Labels

    A-Device-List-TrackingTelling clients about other devices. Often related to E2EE.A-Federated-Joinjoins over federation generally suckA-TestingIssues related to testing in complement, synapse, etcO-FrequentAffects or can be seen by most users regularly or impacts most users' first experienceS-MajorMajor functionality / product severely impaired, no satisfactory workaround.T-TaskRefactoring, removal, replacement, enabling or disabling functionality, other engineering tasks.Z-Dev-WishlistMakes developers' lives better, but doesn't have direct user impactZ-FlakeTests that give intermittent failures

    Type

    No type

    Projects

    No projects

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions