Skip to content
This repository was archived by the owner on Apr 26, 2024. It is now read-only.
This repository was archived by the owner on Apr 26, 2024. It is now read-only.

Audit and/or add validation to synapse/rest/client/account_validity.py #13184

Closed
Closed
Audit and/or add validation to synapse/rest/client/account_validity.py#13184
Labels
A-Validation500 (mostly) errors due to lack of event/parameter validationO-UncommonMost users are unlikely to come across this or unexpected workflowS-TolerableMinor significance, cosmetic issues, low or no impact to users.T-TaskRefactoring, removal, replacement, enabling or disabling functionality, other engineering tasks.Z-Dev-WishlistMakes developers' lives better, but doesn't have direct user impactZ-Help-WantedWe know exactly how to fix this issue, and would be grateful for any contribution
Milestone
Validate data passed to REST endpoints
@DMRobertson

Description

@DMRobertson
DMRobertson
opened on Jul 5, 2022

This is an unspecced endpoint which I think is exposed under /unstable, /api/v1, /r0 and /v3 (#8334). It should be under /_synapse if internal or /unstable if part of an MSC.

That aside:

  • GET AccountValidityRenewServlet, nothing to do here
  • POST AccountValiditySendMailServlet. Seems to take no arguments in the post body. (Probably contravenes a rule that POST to matrix APIs need to have a json object as their body.)

Oh. So these are all fine then.

Metadata

Metadata

Assignees

No one assigned

    Labels

    A-Validation500 (mostly) errors due to lack of event/parameter validationO-UncommonMost users are unlikely to come across this or unexpected workflowS-TolerableMinor significance, cosmetic issues, low or no impact to users.T-TaskRefactoring, removal, replacement, enabling or disabling functionality, other engineering tasks.Z-Dev-WishlistMakes developers' lives better, but doesn't have direct user impactZ-Help-WantedWe know exactly how to fix this issue, and would be grateful for any contribution

    Type

    No type

    Projects

    No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions