Skip to content
This repository was archived by the owner on Apr 26, 2024. It is now read-only.
This repository was archived by the owner on Apr 26, 2024. It is now read-only.

Faster joins: check compatibility with history import #13003

Closed
#14291
Closed
Faster joins: check compatibility with history import#13003
#14291
Assignees
DMRobertson
Labels
A-Federated-Joinjoins over federation generally suckT-EnhancementNew features, changes in functionality, improvements in performance, or user-facing enhancements.
@richvdh

Description

@richvdh
richvdh
opened on Jun 9, 2022

I suspect the MSC2716 code makes incorrect assumptions about whether state is complete at the insertion points.

synapse/synapse/handlers/federation_event.py

Lines 778 to 785 in 7c6b220

state_ids = await self._resolve_state_at_missing_prevs(origin, event)
# TODO(faster_joins): make sure that _resolve_state_at_missing_prevs does
# not return partial state
# https://github.com/matrix-org/synapse/issues/13002
await self._process_received_pdu(
origin, event, state_ids=state_ids, backfilled=backfilled
)

Metadata

Metadata

Assignees

Labels

A-Federated-Joinjoins over federation generally suckT-EnhancementNew features, changes in functionality, improvements in performance, or user-facing enhancements.

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions