Skip to content
This repository was archived by the owner on Apr 26, 2024. It is now read-only.
This repository was archived by the owner on Apr 26, 2024. It is now read-only.

Faster joins: check for partial state when handling backfill #13002

Closed
#13355
Closed
Faster joins: check for partial state when handling backfill#13002
#13355
Assignees
squahtx
Labels
A-Federated-Joinjoins over federation generally suckT-DefectBugs, crashes, hangs, security vulnerabilities, or other reported issues.
Milestone
Q3 2022: Faster joins: fix major known bugs for monoliths
@richvdh

Description

@richvdh
richvdh
opened on Jun 9, 2022

Suppose:

  • We have two chunks of room timeline, each with partial state.
  • We attempt to backfill backwards from the later chunk, and fill the gap (so we reach the earlier chunk)

I think there is a bug here whereby we will incorrectly assume we have full state at the start of the backfilled chunk, which sounds messy.

synapse/synapse/handlers/federation_event.py

Lines 778 to 785 in 7c6b220

state_ids = await self._resolve_state_at_missing_prevs(origin, event)
# TODO(faster_joins): make sure that _resolve_state_at_missing_prevs does
# not return partial state
# https://github.com/matrix-org/synapse/issues/13002
await self._process_received_pdu(
origin, event, state_ids=state_ids, backfilled=backfilled
)

Part of #12646

Metadata

Metadata

Assignees

Labels

A-Federated-Joinjoins over federation generally suckT-DefectBugs, crashes, hangs, security vulnerabilities, or other reported issues.

Type

No type

Projects

No projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions