This repository was archived by the owner on Nov 25, 2022. It is now read-only.
Pull the corresponding complement branch in the Synapse pipeline.#157
Merged
Pull the corresponding complement branch in the Synapse pipeline.#157
Conversation
Member
Author
|
I ran this locally and it seemed OK. |
Member
Author
|
CC @anoadragon453 and @kegsay who I've talked with about this recently. |
anoadragon453
approved these changes
Jun 8, 2021
Member
anoadragon453
left a comment
There was a problem hiding this comment.
Looks good from a cursory review.
kegsay
approved these changes
Jun 8, 2021
Member
kegsay
left a comment
There was a problem hiding this comment.
Looks great, we should do the same for Dendrite!
This was referenced Jun 9, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is similar to what we do in sytest where we run the CI against a matching branch name, if one exists. (Otherwise we fallback to
master.)We'll probably want similar changes on the complement side.