Skip to content

Emit error:preparing if we fire preparing but never make it to ready#87

Merged
t3chguy merged 1 commit intomasterfrom
t3chguy/cr/73
Jul 26, 2023
Merged

Emit error:preparing if we fire preparing but never make it to ready#87
t3chguy merged 1 commit intomasterfrom
t3chguy/cr/73

Conversation

@t3chguy
Copy link
Member

@t3chguy t3chguy commented Jul 26, 2023

Fixes #88

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@t3chguy t3chguy marked this pull request as ready for review July 26, 2023 08:19
@t3chguy t3chguy requested a review from a team as a code owner July 26, 2023 08:19
@t3chguy t3chguy requested review from dbkr and germain-gg and removed request for a team July 26, 2023 08:19
Copy link

@germain-gg germain-gg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks fine, but would it be possible to attach some context?

@t3chguy
Copy link
Member Author

t3chguy commented Jul 26, 2023

@germain-gg sure, attached

@t3chguy t3chguy merged commit ad944d3 into master Jul 26, 2023
@t3chguy t3chguy deleted the t3chguy/cr/73 branch July 26, 2023 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

No way to know that a given widget hasn't and won't reached ready state

2 participants