Add RequiresClient capability#47
Merged
jryans merged 2 commits intomatrix-org:masterfrom Oct 26, 2021
Merged
Conversation
Contributor
|
Unsure if we have it recorded as a style rule, but generally we tend to name PRs in the style "[Title case, active verb] blah blah[no full stop]", so perhaps "Add NoPopout capability" here. |
662c500 to
291bb58
Compare
jryans
reviewed
Oct 25, 2021
src/interfaces/Capabilities.ts
Outdated
| StickerSending = "m.sticker", | ||
| AlwaysOnScreen = "m.always_on_screen", | ||
|
|
||
| // Ask Element to not give the option to move the widget into a seperate tab. |
Contributor
There was a problem hiding this comment.
Suggested change
| // Ask Element to not give the option to move the widget into a seperate tab. | |
| // Ask Element to not give the option to move the widget into a separate tab. |
Contributor
|
Once the typo is fixed, I think this side is ready to go, so request another review once that's done. |
jryans
approved these changes
Oct 26, 2021
Contributor
jryans
left a comment
There was a problem hiding this comment.
This part looks good to me, thanks for working on it! 😄
I'll merge this side now, as that may help with type failures in CI on the React SDK side.
Contributor
|
@turt2live Will we need a release of this layer and update to the new version before the React SDK side is happy? |
Member
|
Almost certainly, yea. Both react-sdk and element-web will need package updates. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR only adds
RequiresClientto the Capability enum.Required for: matrix-org/matrix-react-sdk#7005