Skip to content

Don't change the URL as you scroll around#119

Merged
MadLittleMods merged 1 commit intomainfrom
madlittlemods/115-no-change-url-on-scroll-timeline
Nov 2, 2022
Merged

Don't change the URL as you scroll around#119
MadLittleMods merged 1 commit intomainfrom
madlittlemods/115-no-change-url-on-scroll-timeline

Conversation

@MadLittleMods
Copy link
Copy Markdown
Collaborator

@MadLittleMods MadLittleMods commented Nov 2, 2022 •
edited
Loading

Don't change the URL as you scroll around in the timeline.

Fix #115

Even if we had #72 to page-load the room with a stable URL, it still probably doesn't make sense to change the URL around as you scroll. The content on the page should be consistent with the URL.

I think it does make sense to still change the calendar and text around to make it easy to jump to another day from where you're currently viewing in the surrounding context.

Reverting behavior originally introduced in #71

@MadLittleMods MadLittleMods added T-Defect Something isn't working. Bugs, crashes, or other reported issues. A-archive-room-view The view to look at a room day by day in the archive labels Nov 2, 2022
@MadLittleMods MadLittleMods marked this pull request as ready for review November 2, 2022 09:35
@MadLittleMods MadLittleMods merged commit 91d84fc into main Nov 2, 2022
@MadLittleMods MadLittleMods deleted the madlittlemods/115-no-change-url-on-scroll-timeline branch April 26, 2023 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

A-archive-room-view The view to look at a room day by day in the archive T-Defect Something isn't working. Bugs, crashes, or other reported issues.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Don't change the URL as you scroll around

1 participant

@MadLittleMods