widget-driver: Support for sending future events through the widget api.#3600
widget-driver: Support for sending future events through the widget api.#3600
Conversation
1ae780a to
c7c11e0
Compare
e6f2f48 to
0506014
Compare
1edd88d to
1d3b270
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3600 +/- ##
==========================================
+ Coverage 84.27% 84.28% +0.01%
==========================================
Files 259 259
Lines 26621 26658 +37
==========================================
+ Hits 22435 22470 +35
- Misses 4186 4188 +2 ☔ View full report in Codecov by Sentry. |
043c9ac to
fbb6589
Compare
AndrewFerr
left a comment
There was a problem hiding this comment.
LGTM but I'm not an expert on this codebase :)
andybalaam
left a comment
There was a problem hiding this comment.
I also don't know much about the widget code but this looks OK to me.
bnjbvr
left a comment
There was a problem hiding this comment.
Can you follow the contribution guidelines for good PR titles, please? 🥺
d9fed69 to
99dacc6
Compare
bnjbvr
left a comment
There was a problem hiding this comment.
Also, since future has a very specific meaning in Rust as a name, can you precise everywhere that future refers to a future event (rather than a Future as in async/await) instead, please? 🙏
99dacc6 to
20027c1
Compare
20027c1 to
7ecb9d7
Compare
a5f9f6d to
95edb89
Compare
b199a08 to
48c471b
Compare
bnjbvr
left a comment
There was a problem hiding this comment.
rustfmt found a trailing whitespace 👀 But then, good to go, thanks!
48c471b to
a92cb4b
Compare
|
(To run the rustfmt we're using in the codebase, use |
…re events. We need to disambigute future events and rust futures.
a92cb4b to
48ca240
Compare
This adds support to parse widget actions that contain a future_timeout
as described in MSC matrix-org/matrix-spec-proposals#4157
those actions need to be handled using the custom send_future and state_future cs api endpoint described in: matrix-org/matrix-spec-proposals#4140.
This is supported by ruma and here we only handle the actions from the widget.
This is the core piece of code for that change:
Signed-off-by: