This repository was archived by the owner on Sep 11, 2024. It is now read-only.
test bulk unverified sessions toast behaviour#9655
Merged
kerryarchibald merged 4 commits intodevelopfrom Dec 1, 2022
Merged
Conversation
3 tasks
weeman1337
suggested changes
Nov 30, 2022
Contributor
weeman1337
left a comment
There was a problem hiding this comment.
More tests 👍
The checks, that showToast has not been called should be added. Fine otherwise.
| await createAndStart(); | ||
|
|
||
| expect(mockClient.setAccountData).toHaveBeenCalledWith( | ||
| expect(mockClient!.setAccountData).toHaveBeenCalledWith( |
Contributor
There was a problem hiding this comment.
Maybe just a personal opinion but I would define the variable as always set instead of putting the ! everywhere.
weeman1337
approved these changes
Dec 1, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
This change is marked as an internal change (Task), so will not be included in the changelog.