This repository was archived by the owner on Sep 11, 2024. It is now read-only.
Force style rules of buttons on MessageActionBar used with maskButton selector#8780
Merged
weeman1337 merged 8 commits intomatrix-org:developfrom Jun 8, 2022
luixxiul:MessageActionBar
Merged
Force style rules of buttons on MessageActionBar used with maskButton selector#8780weeman1337 merged 8 commits intomatrix-org:developfrom luixxiul:MessageActionBar
weeman1337 merged 8 commits intomatrix-org:developfrom
luixxiul:MessageActionBar
Conversation
…maskButton Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
…onBar_maskButton Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
…ar_maskButton as expected Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
…adSpinnerButton in mx_MessageActionBar_downloadButton Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
weeman1337
suggested changes
Jun 8, 2022
Contributor
weeman1337
left a comment
There was a problem hiding this comment.
Hi @luixxiul thank you for your contribution.
Can you please check my comment? After resolving this re-request review. It will be much easier for me then.
weeman1337
approved these changes
Jun 8, 2022
Contributor
weeman1337
left a comment
There was a problem hiding this comment.
Tested, works. LGTM 👍
Contributor
Author
|
@weeman1337 thanks for reviewing! |
luixxiul
commented
Jun 8, 2022
| mask-size: 12px; | ||
| mask-image: url('$(res)/img/element-icons/expand-message.svg'); | ||
| } | ||
| &.mx_MessageActionBar_downloadSpinnerButton::after { |
Contributor
Author
There was a problem hiding this comment.
I noticed this nesting was wrong.
This means .mx_MessageActionBar_downloadButton::after.mx_MessageActionBar_downloadSpinnerButton::after, which in fact should be .mx_MessageActionBar_downloadButton.mx_MessageActionBar_downloadSpinnerButton::after.
I'm pushing a fix as follow-up soon.
This was referenced Jun 8, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR tries to ensure that the style rules of buttons on message action bar used with only with
mx_MessageActionBar_maskButtonselector and prevent the styles from being referred/stolen somewhere else.The next task would be to include the rule block of
mx_MessageActionBar_maskButtoninmx_MessageActionBar, which requires analysis as those rules are referred from other files which are irrelevant to the message action bar.Signed-off-by: Suguru Hirahara luixxiul@users.noreply.github.com
type: task
This change is marked as an internal change (Task), so will not be included in the changelog.