This repository was archived by the owner on Sep 11, 2024. It is now read-only.
Stop stealing style rules for the options button on ThreadList#8777
Closed
luixxiul wants to merge 6 commits intomatrix-org:developfrom
luixxiul:ThreadListContextMenu
Closed
Stop stealing style rules for the options button on ThreadList#8777luixxiul wants to merge 6 commits intomatrix-org:developfrom luixxiul:ThreadListContextMenu
luixxiul wants to merge 6 commits intomatrix-org:developfrom
luixxiul:ThreadListContextMenu
Conversation
Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
dbkr
approved these changes
Jun 8, 2022
Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
Contributor
Author
|
The conflict was fixed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The options button on
ThreadListdoes not belong to the message action bar and should have its own style rules. See https://github.com/matrix-org/matrix-react-sdk/blob/3a20cb17038bd8e35b61291ab8eab640f6d333fd/res/css/views/messages/_MessageActionBar.scss for the original rules.Signed-off-by: Suguru Hirahara luixxiul@users.noreply.github.com
type: task
This change is marked as an internal change (Task), so will not be included in the changelog.