This repository was archived by the owner on Sep 11, 2024. It is now read-only.
Normalize inline spacing of image and file button on ThreadView#8664
Merged
SimonBrandner merged 4 commits intomatrix-org:developfrom May 21, 2022
luixxiul:EventTile_mediaLine
Merged
Normalize inline spacing of image and file button on ThreadView#8664SimonBrandner merged 4 commits intomatrix-org:developfrom luixxiul:EventTile_mediaLine
SimonBrandner merged 4 commits intomatrix-org:developfrom
luixxiul:EventTile_mediaLine
Conversation
…layout on ThreadView This normalizes inline spacing of image and file button on ThreadView. The declarations of EventTile_mediaLine was added with 3a2aa9d, and they were expected to align the element with mx_EventTile_content. After the padding-right value for mx_EventTile_content was changed from 50px to 8px with 544957b, the declarations have been obsolete. Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
As padding properties for mx_EventTile_mediaLine were removed, !important flag is no longer required. Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
Contributor
Author
|
This change broke placement of audio player in a thread. I'm pushing a more generalized fix to prevent a similar bug from happening. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR replaces padding of an image and a file button on group layout on ThreadView with margin.
Purple: padding
Yellow: margin
Signed-off-by: Suguru Hirahara luixxiul@users.noreply.github.com
type: task
This change is marked as an internal change (Task), so will not be included in the changelog.