Conversation
turt2live
left a comment
There was a problem hiding this comment.
Thank you for the contribution!
This appears to only touch the one string, but I am sure we have more which could be em dashes. Ultimately though I think this might be something for Design to consider so they can be aware of it for future copy as well.
src/i18n/strings/ar.json
Outdated
| "Deactivate account": "تعطيل الحساب", | ||
| "Deactivate Account": "تعطيل الحساب", | ||
| "Deactivating your account is a permanent action - be careful!": "يعد تعطيل حسابك إجراءً دائمًا - كن حذرًا!", | ||
| "Deactivating your account is a permanent action —— ßbe careful!": "يعد تعطيل حسابك إجراءً دائمًا - كن حذرًا!", |
There was a problem hiding this comment.
translation files not modified by yarn i18n cannot be touched as it causes merge conflicts in the translation system. We'd ultimately have to fix them in the translations system instead.
There was a problem hiding this comment.
Got it. Can you pls guide about how can this be done then
There was a problem hiding this comment.
You should only edit the .tsx file, delete all the other changes and then run yarn i18n which will generate changes to the English translation file. The other translation files are then going to be modified through https://translate.element.io/
There was a problem hiding this comment.
You should only edit the .tsx file, delete all the other changes and then run yarn i18n which will generate changes to the English translation file. The other translation files are then going to be modified through https://translate.element.io/
There was a problem hiding this comment.
I have reversed the changes in .json files. Following the procedure suggested by @SimonBrandner after editing the .tsx file, and running yarn i18n I still can't see any changes in the en_EN.json file. It still looks like this-
There was a problem hiding this comment.
I can still see a bunch of changes JSON files in the diff - did you push the changes? Are you saying that if you change the dash in the .tsx file and then run yarn i18n nothing the en_EN.json file doesn't get updated with the new dash?
There was a problem hiding this comment.
I have pushed the changes. Still, I will check again.
Yes, actually I tried making the changes in a separate branch but nothing changes in the en_EN.json even after running yarn i18n.
There was a problem hiding this comment.
I have pushed all the changes. It can be viewed from the latest commit here
20758ff
There was a problem hiding this comment.
If you go to https://github.com/matrix-org/matrix-react-sdk/pull/8449/files, you can see there still are changes; it seems to be the case that the original code used - while you used —... I would suggest resetting to develop (something like git reset --hard upstream/develop), changing the .tsx file, running yarn i18n and then seeing what happens
There was a problem hiding this comment.
Just to make sure I am not doing anything wrong, I created a new branch did the change in .tsx file. Then ran yarn i18n but nothing is changed in en_EN.json
|
Closing in favour of #8455 |
Fixes: element-hq/element-web#21895
Signed-off-by: Esha Goel goelesha2001@gmail.com
This PR currently has no changelog labels, so will not be included in changelogs.
A reviewer can add one of:
T-Deprecation,T-Enhancement,T-Defect,T-Taskto indicate what type of change this is, or addType: [enhancement/defect/task]to the description and I'll add them for you.