Align NetworkDropdown component with new design#8380
Align NetworkDropdown component with new design#8380germain-gg wants to merge 8 commits intodevelopfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #8380 +/- ##
========================================
Coverage 30.40% 30.41%
========================================
Files 889 889
Lines 50507 50506 -1
Branches 12861 12861
========================================
+ Hits 15359 15360 +1
+ Misses 35148 35146 -2
|
kerryarchibald
left a comment
There was a problem hiding this comment.
Looks super nice!
(Also TIL github renders the svg diff very nicely)
There was a problem hiding this comment.
Minor changes requested. First off, love that you're aligning the components!
I just want to explain the design a little first for context. I noticed the Threads beta has a drop down design and I wanted to mimic the styling, so its consistent with latest dropdowns. I think between my Figma and the actual threads dropdown we have some things to align, I've updated the design here to be more like Threads dropdown (image below)
Default style
- Add
Show:to start of content - Edit border and border radius
- Edit size of chevron to match Threads chevron
Hover style
- Edit border radius
Dropdown style
- Use border and box-shadow style of Threads dropdown
|
Closing as #8707 took over this piece |
Related to element-hq/element-web#21354
This change is marked as an internal change (Task), so will not be included in the changelog.
Preview: https://pr8380--matrix-react-sdk.netlify.app
⚠️ Do you trust the author of this PR? Maybe this build will steal your keys or give you malware. Exercise caution. Use test accounts.