Skip to content
This repository was archived by the owner on Sep 11, 2024. It is now read-only.

Work towards unifying KeyboardShortcuts and KeyBindingsDefaults #1#7651

Merged
t3chguy merged 10 commits intomatrix-org:developfrom
SimonBrandner:task/keybinds-unification-1
Jan 27, 2022
Merged

Work towards unifying KeyboardShortcuts and KeyBindingsDefaults #1#7651
t3chguy merged 10 commits intomatrix-org:developfrom
SimonBrandner:task/keybinds-unification-1

Conversation

@SimonBrandner
Copy link
Contributor

@SimonBrandner SimonBrandner commented Jan 26, 2022

Type: task


I am somewhat conflicted about using ...Action as keys since we are going to merge them into one in the future when they become settings. That being said this is probably fine for now and we can do that in the future


This change is marked as an internal change (Task), so will not be included in the changelog.

Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
@SimonBrandner SimonBrandner requested a review from a team as a code owner January 26, 2022 20:01
@github-actions github-actions bot added the T-Task Refactoring, enabling or disabling functionality, other engineering tasks label Jan 26, 2022
Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
Copy link
Member

@t3chguy t3chguy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks sane, thanks!

@t3chguy t3chguy merged commit 57a5647 into matrix-org:develop Jan 27, 2022
@SimonBrandner SimonBrandner deleted the task/keybinds-unification-1 branch January 27, 2022 16:03
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

T-Task Refactoring, enabling or disabling functionality, other engineering tasks

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants