This repository was archived by the owner on Sep 11, 2024. It is now read-only.
Merged
Conversation
405fd22 to
7a2fbd1
Compare
Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
73a2a03 to
47cbe06
Compare
Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
e17ad78 to
97ff0ec
Compare
Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
97ff0ec to
05b83d1
Compare
SimonBrandner
commented
Sep 27, 2021
| } | ||
|
|
||
| export function getComponent(componentName) { | ||
| export function getComponent(componentName: string): any { |
Contributor
Author
There was a problem hiding this comment.
any because nothing seems to not cause any issues :(
turt2live
reviewed
Sep 27, 2021
Member
turt2live
left a comment
There was a problem hiding this comment.
otherwise looks good - thank you!
| GroupView: "group_view", | ||
| MyGroups: "my_groups", | ||
| }; | ||
| enum PageType { |
Member
There was a problem hiding this comment.
should be able to put export default enum PageType on this line instead of later on where it'll get lost/forgotten.
Contributor
Author
There was a problem hiding this comment.
This sadly isn't a thing :( See microsoft/TypeScript#3320
Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
turt2live
approved these changes
Sep 30, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type: task
Fixes element-hq/element-web#19133
Requires matrix-org/matrix-js-sdk#1954
This change is marked as an internal change (Task), so will not be included in the changelog.
Preview: https://6152aed2f9db149d411d2e10--matrix-react-sdk.netlify.app
⚠️ Do you trust the author of this PR? Maybe this build will steal your keys or give you malware. Exercise caution. Use test accounts.