Skip to content
This repository was archived by the owner on Sep 11, 2024. It is now read-only.

Handle well-known data in the login response#2384

Merged
richvdh merged 2 commits intodevelopfrom
rav/well_known_in_login_response
Dec 24, 2018
Merged

Handle well-known data in the login response#2384
richvdh merged 2 commits intodevelopfrom
rav/well_known_in_login_response

Conversation

@richvdh
Copy link
Member

@richvdh richvdh commented Dec 21, 2018

... as per MSC1730.

@richvdh richvdh requested a review from a team December 21, 2018 09:52
@richvdh
Copy link
Member Author

richvdh commented Dec 21, 2018

clues as to why the CI is broken are welcome.

@turt2live
Copy link
Member

It's complaining about electron, which changed very recently. Should be able to rebase the branch on a modern develop and it'll pick up the appropriate riot-web changes and magically work.

Copy link
Member

@turt2live turt2live left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm once the tests pass

@turt2live
Copy link
Member

Tests would be fixed by matrix-org/matrix-react-end-to-end-tests#43

@richvdh
Copy link
Member Author

richvdh commented Dec 24, 2018

ok, I'm going to assume that the test failures here are unrelated.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants