This repository was archived by the owner on Sep 11, 2024. It is now read-only.
Revert "Add isLocation to ComposerEvent analytics events"#11190
Merged
andybalaam merged 1 commit intodevelopfrom Jul 4, 2023
Merged
Revert "Add isLocation to ComposerEvent analytics events"#11190andybalaam merged 1 commit intodevelopfrom
andybalaam merged 1 commit intodevelopfrom
Conversation
This reverts commit 739a0c7.
t3chguy
approved these changes
Jul 4, 2023
Member
|
Which PR is this reverting? |
Member
Author
|
Good call Rich, sorry for missing that. It reverts #11187 (now added to description too) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
... because although it fixed CI, it broke local development, and the right fix for CI is to land #11186 and element-hq/element-web#25712
Reverts #11187
This change is marked as an internal change (Task), so will not be included in the changelog.