This repository was archived by the owner on Sep 11, 2024. It is now read-only.
Fix: cypress findByTestId and percySnapshotElement do not work together#10947
Merged
Fix: cypress findByTestId and percySnapshotElement do not work together#10947
findByTestId and percySnapshotElement do not work together#10947Conversation
3 tasks
weeman1337
approved these changes
May 22, 2023
bbb0cd7 to
f7a8bc9
Compare
3 tasks
t3chguy
approved these changes
Jul 14, 2023
Member
|
Running a percy test |
Member
|
That unfortunately still did not work |
Member
|
Somehow my earlier change didn't take effect so the test was invalid |
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Fixes element-hq/element-web#25391
Checklist
This change is marked as an internal change (Task), so will not be included in the changelog.