This repository was archived by the owner on Sep 11, 2024. It is now read-only.
Prevent rust-crypto setting from leaking to other tests#10464
Merged
Prevent rust-crypto setting from leaking to other tests#10464
Conversation
t3chguy
approved these changes
Mar 27, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #9759.
Because the MatrixClientPeg pushes the
use_rust_cryptosetting back into theSettingsStore, the setting was leaking out to other tests despitegetValue's mock being restored.The solution is to mock out
setValueas well.This change is marked as an internal change (Task), so will not be included in the changelog.