Skip to content

Require go 1.19 for atomic.Int64#687

Merged
DMRobertson merged 2 commits intomainfrom
dmr/go-version
Oct 30, 2023
Merged

Require go 1.19 for atomic.Int64#687
DMRobertson merged 2 commits intomainfrom
dmr/go-version

Conversation

@DMRobertson
Copy link
Contributor

@DMRobertson DMRobertson commented Oct 30, 2023

Synapse tried to build complement using the go version specificed in go.mod, and failed:

 📦 github.com/matrix-org/complement/internal/docker
Error: internal/docker/deployment.go:29:26: undefined: atomic.Int64

See matrix-org/synapse#16567 (comment) onwards.

@clokep
Copy link
Member

clokep commented Oct 30, 2023

Does the setup-go in this repo need to be updated to enforce this? I.e. these have the same warning:

Warning: go-version input was not specified. The action will try to use pre-installed version.

@DMRobertson
Copy link
Contributor Author

Oh, ISWYM! It feels like it probably ought to.

@DMRobertson DMRobertson merged commit 055c966 into main Oct 30, 2023
@DMRobertson DMRobertson deleted the dmr/go-version branch October 30, 2023 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants