Test content disposition against a content type with a parameter.#664
Merged
Test content disposition against a content type with a parameter.#664
Conversation
kegsay
approved these changes
Oct 9, 2023
| // We need to check that this security behaviour is being correctly run in | ||
| // Synapse, but since this is not part of the Matrix spec we do not assume | ||
| // other homeservers are doing so. | ||
| t.Skip("Skipping test of Content-Disposition header requirements on non-Synapse homeserver") |
Member
There was a problem hiding this comment.
So I guess the reason you're not using runtime.SkipIf is because you want to only run this test on synapse, rather than skip if it is dendrite/conduit?
Member
Author
There was a problem hiding this comment.
It is what the other tests in this file used and I copied & pasted the test to bootstrap. 😄
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See matrix-org/synapse#16440