Skip to content

Add test for failover of federated joins#612

Merged
squahtx merged 1 commit intomainfrom
squah/add_federated_join_failover_test
Feb 15, 2023
Merged

Add test for failover of federated joins#612
squahtx merged 1 commit intomainfrom
squah/add_federated_join_failover_test

Conversation

@squahtx
Copy link
Contributor

@squahtx squahtx commented Feb 15, 2023

When performing a federated join, the homeserver accepts a list of
servers to try joining via. When the first remote server in the list is
not in the room, the federated join ought to try the rest of the list
instead of failing immediately.

Signed-off-by: Sean Quah seanq@matrix.org


Synapse currently fails the test. matrix-org/synapse#15074 fixes it.

When performing a federated join, the homeserver accepts a list of
servers to try joining via. When the first remote server in the list is
not in the room, the federated join ought to try the rest of the list
instead of failing immediately.

Signed-off-by: Sean Quah <seanq@matrix.org>
Copy link
Contributor

@DMRobertson DMRobertson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SGTM!

@squahtx squahtx merged commit a4039f3 into main Feb 15, 2023
@squahtx squahtx deleted the squah/add_federated_join_failover_test branch February 15, 2023 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants