Test that Synapse will purge a room during resync#608
Merged
DMRobertson merged 5 commits intomainfrom Feb 14, 2023
Merged
Conversation
squahtx
approved these changes
Feb 13, 2023
Contributor
squahtx
left a comment
There was a problem hiding this comment.
Test looks good. Thanks for picking this up!
Co-authored-by: Sean Quah <8349537+squahtx@users.noreply.github.com>
Contributor
Author
|
There is a problem with this test: the partial state infrastructure in complement checks to see that a partial state has succeeded by querying /members. But that will fail after the room has been purged. Will think on this tomorrow. |
And ensure we don't flake in the style of matrix-org/synapse#13975
Contributor
Author
|
Thanks Sean for talking this over with me this morning. Could you take another look? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See matrix-org/synapse#15068.
IDK if we want Synapse-specific tests in Synapse, but short of #226 I think this is the least-bad option.