Conversation
squahtx
approved these changes
Jan 26, 2023
Contributor
squahtx
left a comment
There was a problem hiding this comment.
Looks good. Thanks for fixing the flake!
Contributor
Author
|
Merged, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hopefully fixes matrix-org/synapse#14902. In the test, there are two directory lookups, one for a user rod and one for a user todd. When I wrote the test, my assumption was that if rod was showing up in the user directory then todd would show up as well, so I did not retry the lookup for todd. It seems now that I was wrong. I added a retry to todd's lookup, and ran the test ~15 times locally. Not only did it not fail, but I saw several runs where todd's lookup was retried - which in the previous iteration would have been a failure - so I suspect this was the problem.