Add a test using a sync token for relations.#586
Merged
Conversation
This was referenced Jan 18, 2023
DMRobertson
reviewed
Jan 26, 2023
Contributor
DMRobertson
left a comment
There was a problem hiding this comment.
I've left some suggestions about helper functions, but take them with a pinch of salt.
Could we have a comment summarising what the test does and what it checks? Suggestion
Alice starts a thread and sends 10 messages into it.
Check she can paginate backwards through the thread's history, starting from a sync token midway through the thread.
Otherwise LGTM
DMRobertson
reviewed
Jan 26, 2023
Member
Author
|
Thanks for the review @DMRobertson! 🎉 Would you mind taking another look? |
DMRobertson
reviewed
Jan 27, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tests for matrix-org/synapse#14866.