Change tests to accomodate non blocking regular sync#584
Change tests to accomodate non blocking regular sync#584
Conversation
DMRobertson
left a comment
There was a problem hiding this comment.
Some nitpicks about naming aside, I'm happy if CI is.
There was a problem hiding this comment.
I think we're missing a test case here.
Suppose that we
- we an do incremental, non-lazy sync, getting since_token
1. - we partially join a room.
- we incremental, nonlazy sync from since_token
1and get since_token2.- The response here should not include the room. Is this tested?
- someone sends a message to the room.
- We incremental, nonlazy sync from since_token
2and get since_token3.- The response here should not include the room. Is this tested?
- The resync completes.
- We incremental, nonlazy sync from since_token
3and get since_token4. - The response here should include the room. I think this is tested?
- We incremental, nonlazy sync from since_token
(I think in this diff we only cover partial joins with an initial, nonlazy sync?)
|
|
||
| // initial sync shouldn't include the room yet, but still return immediatly | ||
| response, nextBatch := alice.MustSync(t, client.SyncReq{ | ||
| TimeoutMillis: "10000", |
There was a problem hiding this comment.
I'm not sure this adds anything since MustSync uses a timeout of 1000 by default:
complement/internal/client/client.go
Lines 307 to 309 in 0af85cf
I also think I got myself confused when writing up the comment last night.
I've had a go at this in #588.
There was a problem hiding this comment.
MV: this isn't addressing the comment of dmr above, this is about the notifier changes (see synapse PR)
|
Superseded by #588 |
No description provided.