Homerunner: Permit running HS with remote networking, and provide docker build#560
Merged
kegsay merged 5 commits intomatrix-org:mainfrom Nov 29, 2022
Conversation
(also some gitignore changes because the directory cmd/homerunner/ was being ignored.
michaelkaye
commented
Nov 21, 2022
| .idea | ||
| .bin | ||
| .DS_Store | ||
| homerunner No newline at end of file |
Contributor
Author
There was a problem hiding this comment.
(required as we were ignoring changes to the homerunner directory)
kegsay
approved these changes
Nov 29, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The aim of this PR is to allow homerunner to start servers using docker-dind, and make them available over a non-local network. We can take advantage of this in a k8s environment by running servers on the PodIP, and so make them available outside of the pod.
This is wanted for trafficlight, where a adapters wrap and automate real clients (eg, ios/android/web) and so running many of them can be heavyweight. Currently we can run everything locally on a single desktop, but managing simultaneous runs of multiple tests needs us to spread the load across hosts.
The change should be a noop for complement run tests, retaining the default behaviour there, and without a configuration option being set, is also a noop for homerunner users.
If we wanted, this could also allow running a homerunner as a hosted service outside of k8s, with the resultant servers available over the network.