Add presence test from people in 2 different rooms in incremental sync#525
Merged
DMRobertson merged 9 commits intomainfrom Oct 27, 2022
Merged
Add presence test from people in 2 different rooms in incremental sync#525DMRobertson merged 9 commits intomainfrom
DMRobertson merged 9 commits intomainfrom
Conversation
Signed-off-by: Mathieu Velten <mathieuv@matrix.org>
4 tasks
added 2 commits
October 20, 2022 18:22
ShadowJonathan
suggested changes
Oct 21, 2022
ShadowJonathan
suggested changes
Oct 21, 2022
Co-authored-by: Jonathan de Jong <jonathan@automatia.nl>
Contributor
For future reference: if you make the complement branch and the Synapse branch the same, they will be tested against each other. Will rerun now that I merged the Synapse PR. |
DMRobertson
reviewed
Oct 27, 2022
tests/csapi/sync_test.go
Outdated
| bob.DoFunc(t, "PUT", []string{"_matrix", "client", "v3", "presence", "@bob:hs1", "status"}, reqBody) | ||
| charlie.DoFunc(t, "PUT", []string{"_matrix", "client", "v3", "presence", "@charlie:hs1", "status"}, reqBody) | ||
|
|
||
| presenceBob, presenceCharlie := false, false |
Contributor
There was a problem hiding this comment.
We should spell out what we're doing here.
I think I'd call these seenBobOnline and seenCharlieOnline.
DMRobertson
approved these changes
Oct 27, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will fail for now, and should be fixed by matrix-org/synapse#14243.