Conversation
added 8 commits
September 23, 2022 18:54
Contributor
Author
|
We expect these tests to fail until matrix-org/synapse#13891 is ready. |
c541851 to
e2afad0
Compare
This was referenced Sep 23, 2022
erikjohnston
approved these changes
Sep 27, 2022
Member
erikjohnston
left a comment
There was a problem hiding this comment.
The logic for some of these tests are quite confusing, but I don't have any suggestions on how to make it better :(
|
|
||
| // setupIncorrectlyAcceptedKick joins the homeserver under test to a room, then joins | ||
| // @elsie:server2 and sends an invalid event to kick @elsie:server2 from the room. | ||
| setupIncorrectlyAcceptedKick := func( |
Member
There was a problem hiding this comment.
We should probably comment that this causes derek to leave the room?
Contributor
Author
There was a problem hiding this comment.
Good idea, let's do that.
This was referenced Sep 28, 2022
Base automatically changed from
squah/faster_room_joins_device_list_tracking_outgoing_1
to
main
September 29, 2022 12:51
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Test that outgoing device list updates reach servers incorrectly thought
to not be in a partial state room once the room transitions to full
state.
Built on top of #473.
Best reviewed commit by commit.