Make handleGetMissingEventsRequests more general#428
Merged
Conversation
A few changes: * make it check the requested `latest_events` to check that we are replying to the request we think we are * Use the structures in `gomatrixserverlib` rather than defining our own * General cleanups
50aa422 to
bd85d39
Compare
squahtx
reviewed
Jul 26, 2022
Contributor
squahtx
left a comment
There was a problem hiding this comment.
Was the serverRoom *federation.ServerRoom -> roomID string change reverted by accident? It looked sensible
Otherwise lgtm
Member
Author
I decided it made it match the handleStateRequest things better to leave it as serverRoom. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A few changes:
latest_eventsto check that we are replying to the request we think we aregomatrixserverlibrather than defining our own