Fix flakey TestRoomReceiptsReadMarkers#393
Merged
erikjohnston merged 2 commits intomainfrom Jun 13, 2022
Merged
Conversation
We can't do the tests in parallel, as sending a `/receipt` request after a `/read_markers` request on the same event returns an error. (While `/read_markers` will return 200 in the reversed situation).
squahtx
approved these changes
Jun 13, 2022
Contributor
squahtx
left a comment
There was a problem hiding this comment.
one comment, otherwise lgtm
| alice := deployment.Client(t, "hs1", "@alice:hs1") | ||
| roomID := alice.CreateRoom(t, map[string]interface{}{"preset": "public_chat"}) | ||
|
|
||
| // sytest: POST /rooms/:room_id/receipt can create receipts |
Contributor
There was a problem hiding this comment.
the doc comments could do with being moved up to before func TestRoomReceipts and func TestRoomMarkers
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We can't do the tests in parallel, as sending a
/receiptrequest aftera
/read_markersrequest on the same event returns an error. (While/read_markerswill return 200 in the reversed situation).We fix it by splitting the test into two.
Example logs from a failed run: